custom error enums for state and token methods #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #15 |
anorth
approved these changes
Jul 20, 2022
| #[error("underlying serialization error: {0}")] | ||
| Serialization(String), | ||
| #[error( | ||
| "negative balance caused by subtracting {delta:?} from {owner:?}'s balance of {balance:?}" |
There was a problem hiding this comment.
The delta here will be negative when subtracting, so this double negative will be confusing.
Instead: "negative balance caused by adding -1000 to owner's balance of 200". Or "changing balance by xxx"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces use internal use of anyhow with custom error structs
The
fvm_ipld_blockstore::Blockstoretrait depends exports an interface withanyhow::Resultso it can't be dropped as a dependency for now.